On Tue, Sep 27, 2022 at 03:54:26PM -0600, Alex Williamson wrote: > Oops, I had to drop this, I get a null pointer from gvt-g code: Ok, this is a stupid bug in the second patch in the series. I did not hit it in my mdev testing as my script just uses the first type and thus never hits these, but as your trace showed mdevctl and once I used that I could reproduce it. The fix for patch 2 is below, and the git tree at: git://git.infradead.org/users/hch/misc.git mvdev-lifetime has been updated with that folded in and the recent reviews. --- diff --git a/drivers/gpu/drm/i915/gvt/vgpu.c b/drivers/gpu/drm/i915/gvt/vgpu.c index 1b67328c714f1..b0d5dafd013f4 100644 --- a/drivers/gpu/drm/i915/gvt/vgpu.c +++ b/drivers/gpu/drm/i915/gvt/vgpu.c @@ -123,7 +123,7 @@ int intel_gvt_init_vgpu_types(struct intel_gvt *gvt) sprintf(gvt->types[i].name, "GVTg_V%u_%s", GRAPHICS_VER(gvt->gt->i915) == 8 ? 4 : 5, conf->name); - gvt->types->conf = conf; + gvt->types[i].conf = conf; gvt->types[i].avail_instance = min(low_avail / conf->low_mm, high_avail / conf->high_mm);
