On Tue, Sep 27, 2022 at 06:26:41AM -0400, Marc Zyngier wrote: > > +static inline bool kvm_dirty_ring_check_request(struct kvm_vcpu *vcpu) > > +{ > > + return false; > > +} > > + > > nit: I don't think this is needed at all. The dirty ring feature is > not user-selectable, and this is always called from arch code that is > fully aware of that option. Agreed. With the change: Reviewed-by: Peter Xu <peterx@xxxxxxxxxx> Thanks, -- Peter Xu