On Thu, Sep 22, 2022, David Matlack wrote: > On Thu, Sep 22, 2022 at 10:40 AM Sean Christopherson <seanjc@xxxxxxxxxx> wrote: > > > > On Thu, Sep 22, 2022, David Matlack wrote: > > > > +LIBKVM_STRING += lib/kvm_string.c > > > > > > Can this file be named lib/string.c instead? This file has nothing to do > > > with KVM per-se. > > > > Yes and no. I deliberately chose kvm_string to avoid confusion with > > tools/lib/string.c and tools/include/nolibc/string.h. The implementations > > themselves aren't KVM specific, but the reason the file _exists_ is 100% unique > > to KVM as there is no other environment where tools and/or selftests link to > > glibc but need to override the string ops. > > > > I'm not completely opposed to calling it string.c, but my preference is to keep > > it kvm_string.c so that it's slightly more obvious that KVM selftests are a > > special snowflake. > > Makes sense, the "kvm" prefix just made me do a double-take. Perhaps > string_overrides.c? That would make it clear that this file is > overriding string functions. And the fact that this file is in the KVM > selftests directory signals that the overrides are specific to the KVM > selftests. I like that, string_overrides.c it is.
