On Tue, 9 Aug 2022 13:48:16 +0100, Suzuki K Poulose wrote: > When a script is specified for a guest nic setup, we fork() and execl()s > the script when it is time to execute the script. However this is not > optimal, given we are running a VM. The fork() will trigger marking the > entire page-table of the current process as CoW, which will trigger > unmapping the entire stage2 page tables from the guest. Anyway, the > child process will exec the script as soon as we fork(), making all > these mm operations moot. Also, this operation could be problematic > for confidential compute VMs, where it may be expensive (and sometimes > destructive) to make changes to the stage2 page tables. > > [...] Applied to kvmtool (master), thanks! [1/1] net: Use vfork() instead of fork() for script execution https://git.kernel.org/will/kvmtool/c/9987a37cfc57 Cheers, -- Will https://fixes.arm64.dev https://next.arm64.dev https://will.arm64.dev