Re: [PATCH 1/9] hw/riscv/sifive_e: Fix inheritance of SiFiveEState

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Am 21. September 2022 04:55:02 UTC schrieb Markus Armbruster <armbru@xxxxxxxxxx>:
>Bernhard Beschow <shentey@xxxxxxxxx> writes:
>
>> Am 20. September 2022 11:36:47 UTC schrieb Markus Armbruster <armbru@xxxxxxxxxx>:
>>>Alistair Francis <alistair23@xxxxxxxxx> writes:
>>>
>>>> On Tue, Sep 20, 2022 at 9:18 AM Bernhard Beschow <shentey@xxxxxxxxx> wrote:
>>>>>
>>>>> SiFiveEState inherits from SysBusDevice while it's TypeInfo claims it to
>>>>> inherit from TYPE_MACHINE. This is an inconsistency which can cause
>>>>> undefined behavior such as memory corruption.
>>>>>
>>>>> Change SiFiveEState to inherit from MachineState since it is registered
>>>>> as a machine.
>>>>>
>>>>> Signed-off-by: Bernhard Beschow <shentey@xxxxxxxxx>
>>>>
>>>> Reviewed-by: Alistair Francis <alistair.francis@xxxxxxx>
>>>
>>>To the SiFive maintainers: since this is a bug fix, let's merge it right
>>>away.
>>
>> I could repost this particular patch with the three new tags (incl. Fixes) if desired.
>
>Can't hurt, and could help the maintainers.

[X] Done.

Best regards,
Bernhard




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux