On Fri, Sep 16, 2022 at 3:03 AM JinrongLiang <ljr.kernel@xxxxxxxxx> wrote: > > > > On 2022/9/8 00:54, Liam Merwick wrote: > > On 07/09/2022 17:01, Sean Christopherson wrote: > >> On Tue, Aug 02, 2022, Jinrong Liang wrote: > >>> From: Jinrong Liang <cloudliang@xxxxxxxxxxx> > >>> > >>> The following warning appears when executing: > >>> make -C tools/testing/selftests/kvm > >>> > >>> rseq_test.c: In function ‘main’: > >>> rseq_test.c:237:33: warning: implicit declaration of function > >>> ‘gettid’; did you mean ‘getgid’? [-Wimplicit-function-declaration] > >>> (void *)(unsigned long)gettid()); > >>> ^~~~~~ > >>> getgid > >>> /usr/bin/ld: /tmp/ccr5mMko.o: in function `main': > >>> ../kvm/tools/testing/selftests/kvm/rseq_test.c:237: undefined > >>> reference to `gettid' > >>> collect2: error: ld returned 1 exit status > >>> make: *** [../lib.mk:173: > >>> ../kvm/tools/testing/selftests/kvm/rseq_test] Error 1 > >>> > >>> Use the more compatible syscall(SYS_gettid) instead of gettid() to > >>> fix it. > >>> More subsequent reuse may cause it to be wrapped in a lib file. > >>> > >>> Signed-off-by: Jinrong Liang <cloudliang@xxxxxxxxxxx> > >>> --- > >> > >> Reviewed-by: Sean Christopherson <seanjc@xxxxxxxxxx> > >> > > > > Can a 'Cc: stable@xxxxxxxxxxxxxxx' be added also as e923b0537d28 got > > backported to v5.15.58 > > > > Reviewed-by: Liam Merwick <liam.merwick@xxxxxxxxxx> > > > > > >> > >> Paolo, do you want to grab this for 6.0? It doesn't look like we're > >> going to have > >> a more elegant solution anytime soon... > > > Ping? +1, please grab this. Every new branch I create (for new development and to review upstream code) I have to remember to cherry-pick this patch in because I use Clang.