On Thu, Sep 15, 2022 at 02:10:43PM +0530, Mukesh Ojha wrote:
> Hi,
>
> On 9/15/2022 2:08 PM, Zeng Heng wrote:
> > Remove unused function argument, and there is
> > no logic changes.
> >
> > Signed-off-by: Zeng Heng <zengheng4@xxxxxxxxxx>
> > ---
> > include/linux/kvm_host.h | 2 +-
> > include/linux/rcutiny.h | 2 +-
> > include/linux/rcutree.h | 2 +-
> > 3 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
> > index f4519d3689e1..9cf0c503daf5 100644
> > --- a/include/linux/kvm_host.h
> > +++ b/include/linux/kvm_host.h
> > @@ -417,7 +417,7 @@ static __always_inline void guest_context_enter_irqoff(void)
> > */
> > if (!context_tracking_guest_enter()) {
> > instrumentation_begin();
> > - rcu_virt_note_context_switch(smp_processor_id());
> > + rcu_virt_note_context_switch();
> > instrumentation_end();
> > }
> > }
> > diff --git a/include/linux/rcutiny.h b/include/linux/rcutiny.h
> > index 768196a5f39d..9bc025aa79a3 100644
> > --- a/include/linux/rcutiny.h
> > +++ b/include/linux/rcutiny.h
> > @@ -142,7 +142,7 @@ static inline int rcu_needs_cpu(void)
> > * Take advantage of the fact that there is only one CPU, which
> > * allows us to ignore virtualization-based context switches.
> > */
> > -static inline void rcu_virt_note_context_switch(int cpu) { }
> > +static inline void rcu_virt_note_context_switch(void) { }
> > static inline void rcu_cpu_stall_reset(void) { }
> > static inline int rcu_jiffies_till_stall_check(void) { return 21 * HZ; }
> > static inline void rcu_irq_exit_check_preempt(void) { }
> > diff --git a/include/linux/rcutree.h b/include/linux/rcutree.h
> > index 5efb51486e8a..70795386b9ff 100644
> > --- a/include/linux/rcutree.h
> > +++ b/include/linux/rcutree.h
> > @@ -27,7 +27,7 @@ void rcu_cpu_stall_reset(void);
> > * wrapper around rcu_note_context_switch(), which allows TINY_RCU
> > * to save a few bytes. The caller must have disabled interrupts.
> > */
> > -static inline void rcu_virt_note_context_switch(int cpu)
> > +static inline void rcu_virt_note_context_switch(void)
> > {
> > rcu_note_context_switch(false);
> > }
>
> Good catch.
>
> Acked-by: Mukesh Ojha <quic_mojha@xxxxxxxxxxx>
Applied for further review and testing. Thank you both!
Thanx, Paul
