Re: [PATCH v5 1/5] KVM: Implement dirty quota-based throttling of vcpus

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Shivam,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on kvm/queue]
[also build test WARNING on mst-vhost/linux-next linus/master v6.0-rc5 next-20220912]
[cannot apply to kvms390/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Shivam-Kumar/KVM-Dirty-quota-based-throttling/20220912-123509
base:   https://git.kernel.org/pub/scm/virt/kvm/kvm.git queue
reproduce:
        # https://github.com/intel-lab-lkp/linux/commit/772b4ec9f5aee3af7759fe673b6c1e157e7afb8d
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Shivam-Kumar/KVM-Dirty-quota-based-throttling/20220912-123509
        git checkout 772b4ec9f5aee3af7759fe673b6c1e157e7afb8d
        make menuconfig
        # enable CONFIG_COMPILE_TEST, CONFIG_WARN_MISSING_DOCUMENTS, CONFIG_WARN_ABI_ERRORS
        make htmldocs

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> Documentation/virt/kvm/api.rst:6630: WARNING: Block quote ends without a blank line; unexpected unindent.

vim +6630 Documentation/virt/kvm/api.rst

  6618	
  6619			/* KVM_EXIT_DIRTY_QUOTA_EXHAUSTED */
  6620			struct {
  6621				__u64 count;
  6622				__u64 quota;
  6623			} dirty_quota_exit;
  6624	If exit reason is KVM_EXIT_DIRTY_QUOTA_EXHAUSTED, it indicates that the VCPU has
  6625	exhausted its dirty quota. The 'dirty_quota_exit' member of kvm_run structure
  6626	makes the following information available to the userspace:
  6627		'count' field: the current count of pages dirtied by the VCPU, can be
  6628	        skewed based on the size of the pages accessed by each vCPU.
  6629		'quota' field: the observed dirty quota just before the exit to userspace.
> 6630	The userspace can design a strategy to allocate the overall scope of dirtying
  6631	for the VM among the vcpus. Based on the strategy and the current state of dirty
  6632	quota throttling, the userspace can make a decision to either update (increase)
  6633	the quota or to put the VCPU to sleep for some time.
  6634	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux