On Wed, Sep 07, 2022 at 01:56:57PM +0800, Yuan Yao <yuan.yao@xxxxxxxxxxxxxxx> wrote: > > +static void hardware_enable(void *arg) > > +{ > > + atomic_t *failed = arg; > > + > > + if (__hardware_enable((void *)__func__)) > > + atomic_inc(failed); > > } > > A side effect: The actual caller_name information introduced in Patch > 3 for hardware_enable() is lost. I tend to keep the information, but > depends on you and other guys. :-) That's true. But only kvm_arch_add_vm() calls hardware_enable() and other call sites are converted to call __hardware_enable(). There is no confusion with other callers with this patch series. So I decided not to bother to pass function name in addition to a failed counter. -- Isaku Yamahata <isaku.yamahata@xxxxxxxxx>