[AMD Official Use Only - General] > -----Original Message----- > From: Saravana Kannan <saravanak@xxxxxxxxxx> > Sent: Wednesday, August 17, 2022 9:34 PM > To: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> > Cc: Gupta, Nipun <Nipun.Gupta@xxxxxxx>; robh+dt@xxxxxxxxxx; > krzysztof.kozlowski+dt@xxxxxxxxxx; rafael@xxxxxxxxxx; eric.auger@xxxxxxxxxx; > alex.williamson@xxxxxxxxxx; cohuck@xxxxxxxxxx; Gupta, Puneet (DCG-ENG) > <puneet.gupta@xxxxxxx>; song.bao.hua@xxxxxxxxxxxxx; > mchehab+huawei@xxxxxxxxxx; maz@xxxxxxxxxx; f.fainelli@xxxxxxxxx; > jeffrey.l.hugo@xxxxxxxxx; Michael.Srba@xxxxxxxxx; mani@xxxxxxxxxx; > yishaih@xxxxxxxxxx; jgg@xxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx; kvm@xxxxxxxxxxxxxxx; okaya@xxxxxxxxxx; Anand, > Harpreet <harpreet.anand@xxxxxxx>; Agarwal, Nikhil > <nikhil.agarwal@xxxxxxx>; Simek, Michal <michal.simek@xxxxxxx>; git > (AMD-Xilinx) <git@xxxxxxx> > Subject: Re: [RFC PATCH v2 6/6] driver core: add compatible string in sysfs for > platform devices > > [CAUTION: External Email] > > On Wed, Aug 17, 2022 at 8:31 AM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> > wrote: > > > > On Wed, Aug 17, 2022 at 08:35:42PM +0530, Nipun Gupta wrote: > > > This change adds compatible string for the platform based > > > devices. > > > > What exactly is a "compatible string"? > > Didn't read the rest of the patches in the series yet, but Nack to > this. This info is already available under: > > <device folder>/of_node/compatible for any device in any (or at least > most) bus that was created from an of_node. > > Unless compatible is now also in ACPI. In which case, it's probably be > better to have an of_node like symlink. We will not be going with platform devices for CDX bus and would rather have CDX devices: https://lore.kernel.org/lkml/DM6PR12MB30827577D50AB1B877458923E8799@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/ So, this change is not valid for us. We would not be having this in Rev V3. - Nipun
