FYI, reverted: http://autotest.kernel.org/changeset/4227 On Sun, Feb 7, 2010 at 11:11 PM, Lucas Meneghel Rodrigues <lmr@xxxxxxxxxx> wrote: > On Sun, 2010-02-07 at 12:59 -0500, Michael Goldish wrote: >> ----- "Lucas Meneghel Rodrigues" <lmr@xxxxxxxxxx> wrote: >> >> > The way tests are currently defined, running unattended >> > install + hugepages will allways skip unattended install >> > setup step (coincidentally the tests on our test farm >> > were working because previous executions of the unattended >> > install script ran, leaving the environment prepared for >> > unattended install). >> > >> > So, make sure pre_commands on default tests.cfg file are >> > additive, and the preprocessor splits the pre_command >> > string, and executes pre/post commands in sequence. >> > >> > Signed-off-by: Lucas Meneghel Rodrigues <lmr@xxxxxxxxxx> >> >> Why not just append ';' to each command? >> >> For example: >> >> pre_command = "scripts/unattended.py;" >> ... >> pre_command += " scripts/hugepage.py;" >> >> (the quotes can be omitted) >> >> IMO this is simpler. > > Yes, agreed. Will revert the patch and fix this. > > _______________________________________________ > Autotest mailing list > Autotest@xxxxxxxxxxxxxxx > http://test.kernel.org/cgi-bin/mailman/listinfo/autotest > -- Lucas -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
