On Wed, Aug 31, 2022, Maxim Levitsky wrote: > On Wed, 2022-08-31 at 00:35 +0000, Sean Christopherson wrote: > > Explicitly skip the optimized map setup if the vCPU's LDR is '0', i.e. if > > the vCPU will never response to logical mode interrupts. KVM already > > skips setup in this case, but relies on kvm_apic_map_get_logical_dest() > > to generate mask==0. KVM still needs the mask=0 check as a non-zero LDR > > can yield mask==0 depending on the mode, but explicitly handling the LDR > > will make it simpler to clean up the logical mode tracking in the future. > > If I am not mistaken, the commit description is a bit misleading - in this > case we just don't add the vCPU to the map since it is unreachable, but we do > continue creating the map. I'll reword. I intended that to mean "skip the optimized setup for the vCPU", but even that is unnecessarily confusing.