On 2022/8/31 9:07, Huang, Kai wrote: >> On Tue, Aug 30, 2022, Huang, Kai wrote: >>> On Tue, 2022-08-30 at 21:40 +0000, Sean Christopherson wrote: >>>> On Tue, Aug 23, 2022, Miaohe Lin wrote: >>>>> When register_shrinker() fails, we forgot to release the percpu >>>>> counter >>> >>>>> kvm_total_used_mmu_pages leading to memoryleak. Fix this issue by >>>>> calling >>>>> percpu_counter_destroy() when register_shrinker() fails. >>>>> >>>>> Fixes: ab271bd4dfd5 ("x86: kvm: propagate register_shrinker return >>>>> code") >>>>> Signed-off-by: Miaohe Lin <linmiaohe@xxxxxxxxxx> >>>>> --- >>>> >>>> Pushed to branch `for_paolo/6.1` at: >>>> >>>> https://github.com/sean-jc/linux.git >>>> >>>> Unless you hear otherwise, it will make its way to kvm/queue "soon". >>>> >>>> Note, the commit IDs are not guaranteed to be stable. >>> >>> Sorry for late reply. >>> >>> The commit message has "we". Should we get rid of it? >> >> Avoiding pronouns is obviously my preference, but sometimes even I set aside >> my crusade to move things along :-) > > Yeah sure. I was replying just in case you didn't notice it :) Please ignore my previous question in another thread. I just saw this patch. ;) Many thanks. > > . >