David Matlack <dmatlack@xxxxxxxxxx> writes:
On Wed, Aug 17, 2022 at 09:41:46PM +0000, Colton Lewis wrote:
@@ -271,6 +272,9 @@ static void run_test(enum vm_guest_mode mode, void
*arg)
pr_info("Enabling dirty logging time: %ld.%.9lds\n\n",
ts_diff.tv_sec, ts_diff.tv_nsec);
+ /* Set random access here, after population phase. */
+ perf_test_set_random_access(vm, p->random_access);
Optional suggestion: We don't have any use-case for disabling random
access, so perhaps this would be simpler as:
if (p->random_access)
perf_test_enable_random_access(vm);
And then:
void perf_test_enable_random_access(struct kvm_vm *vm)
{
perf_test_args.random_access = true;
sync_global_to_guest(vm, perf_test_args);
}
I don't think it's simpler and it's less flexible.
