Re: [PATCH v2 1/3] vfio/pci: Split linux/vfio_pci_core.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 26 2022, Jason Gunthorpe <jgg@xxxxxxxxxx> wrote:

> The header in include/linux should have only the exported interface for
> other vfio_pci module's to use.  Internal definitions for vfio_pci.ko

s/module's/modules/

> should be in a "priv" header along side the .c files.
>
> Move the internal declarations out of vfio_pci_core.h. They either move to
> vfio_pci_priv.h or to the C file that is the only user.
>
> Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>
> Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxx>
> ---
>  drivers/vfio/pci/vfio_pci.c        |   2 +-
>  drivers/vfio/pci/vfio_pci_config.c |   2 +-
>  drivers/vfio/pci/vfio_pci_core.c   |  19 +++-
>  drivers/vfio/pci/vfio_pci_igd.c    |   2 +-
>  drivers/vfio/pci/vfio_pci_intrs.c  |  16 +++-
>  drivers/vfio/pci/vfio_pci_priv.h   | 106 +++++++++++++++++++++++
>  drivers/vfio/pci/vfio_pci_rdwr.c   |   2 +-
>  drivers/vfio/pci/vfio_pci_zdev.c   |   2 +-
>  include/linux/vfio_pci_core.h      | 134 +----------------------------
>  9 files changed, 145 insertions(+), 140 deletions(-)
>  create mode 100644 drivers/vfio/pci/vfio_pci_priv.h

Reviewed-by: Cornelia Huck <cohuck@xxxxxxxxxx>




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux