On Wed, Aug 17, 2022 at 01:07:25PM -0300, Jason Gunthorpe wrote: > This is the last sizable implementation in vfio_group_fops_unl_ioctl(), > move it to a function so vfio_group_fops_unl_ioctl() is emptied out. > > Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxx> > --- > drivers/vfio/vfio_main.c | 55 ++++++++++++++++++++-------------------- > 1 file changed, 27 insertions(+), 28 deletions(-) > > diff --git a/drivers/vfio/vfio_main.c b/drivers/vfio/vfio_main.c > index 78957f45c37a34..6f96e6d07a5e98 100644 > --- a/drivers/vfio/vfio_main.c > +++ b/drivers/vfio/vfio_main.c > @@ -1227,6 +1227,32 @@ static int vfio_group_ioctl_get_device_fd(struct vfio_group *group, > vfio_device_put(device); > return ret; > } > +static int vfio_group_ioctl_get_status(struct vfio_group *group, > + struct vfio_group_status __user *arg) There is a missing blank line after the } here Jason