On Fri, Aug 26, 2022 at 11:45 AM Vipin Sharma <vipinsh@xxxxxxxxxx> wrote: > > Variable set via -g are also indirectly set by -e option by omitting > break statement. Set them explicitly so that movement of switch-case > statements does not unintentionally break features. > > No functional change intended. > > Signed-off-by: Vipin Sharma <vipinsh@xxxxxxxxxx> > --- > tools/testing/selftests/kvm/dirty_log_perf_test.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tools/testing/selftests/kvm/dirty_log_perf_test.c b/tools/testing/selftests/kvm/dirty_log_perf_test.c > index f99e39a672d3..a03db7f9f4c0 100644 > --- a/tools/testing/selftests/kvm/dirty_log_perf_test.c > +++ b/tools/testing/selftests/kvm/dirty_log_perf_test.c > @@ -411,6 +411,8 @@ int main(int argc, char *argv[]) > case 'e': > /* 'e' is for evil. */ > run_vcpus_while_disabling_dirty_logging = true; > + dirty_log_manual_caps = 0; > + break; @Sean, I hope you intentionally didn't write a break between -e and -g when you created the patch and it is not just a missed thing :) > case 'g': > dirty_log_manual_caps = 0; > break; > -- > 2.37.2.672.g94769d06f0-goog >
