The include/linux header should only include things that are intended to be used outside the internal implementation of the vfio_pci_core module. Several internal-only items were left over in this file after the conversion from vfio_pci. Transfer most of the items to a new vfio_pci_priv.h located under drivers/vfio/pci/. v2: - Add "vfio/pci: Rename vfio_pci_register_dev_region()"v1: https://lore.kernel.org/r/0-v1-da6fc51ee22e+562-vfio_pci_priv_jgg@xxxxxxxxxx v1: https://lore.kernel.org/r/0-v1-da6fc51ee22e+562-vfio_pci_priv_jgg@xxxxxxxxxx Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxx> Jason Gunthorpe (3): vfio/pci: Split linux/vfio_pci_core.h vfio/pci: Rename vfio_pci_register_dev_region() vfio/pci: Simplify the is_intx/msi/msix/etc defines drivers/vfio/pci/vfio_pci.c | 2 +- drivers/vfio/pci/vfio_pci_config.c | 4 +- drivers/vfio/pci/vfio_pci_core.c | 29 ++++-- drivers/vfio/pci/vfio_pci_igd.c | 8 +- drivers/vfio/pci/vfio_pci_intrs.c | 28 +++++- drivers/vfio/pci/vfio_pci_priv.h | 104 +++++++++++++++++++++ drivers/vfio/pci/vfio_pci_rdwr.c | 2 +- drivers/vfio/pci/vfio_pci_zdev.c | 2 +- include/linux/vfio_pci_core.h | 140 +---------------------------- 9 files changed, 167 insertions(+), 152 deletions(-) create mode 100644 drivers/vfio/pci/vfio_pci_priv.h base-commit: 1c23f9e627a7b412978b4e852793c5e3c3efc555 -- 2.37.2