On Wed, Aug 24, 2022 at 10:08:41PM -0700, Reiji Watanabe wrote: > Add helpers to enable breakpoint and watchpoint exceptions. > > Signed-off-by: Reiji Watanabe <reijiw@xxxxxxxxxx> > --- > .../selftests/kvm/aarch64/debug-exceptions.c | 25 ++++++++++--------- > 1 file changed, 13 insertions(+), 12 deletions(-) > > diff --git a/tools/testing/selftests/kvm/aarch64/debug-exceptions.c b/tools/testing/selftests/kvm/aarch64/debug-exceptions.c > index 183ee16acb7d..713c7240b680 100644 > --- a/tools/testing/selftests/kvm/aarch64/debug-exceptions.c > +++ b/tools/testing/selftests/kvm/aarch64/debug-exceptions.c > @@ -128,10 +128,20 @@ static void enable_os_lock(void) > GUEST_ASSERT(read_sysreg(oslsr_el1) & 2); > } > > +static void enable_debug_bwp_exception(void) uber-nit: enable_monitor_debug_exceptions() (more closely matches the definition of MDSCR_EL1.MDE) With that: Reviewed-by: Oliver Upton <oliver.upton@xxxxxxxxx> -- Thanks, Oliver