Re: [PATCH v7 1/4] mm: add NR_SECONDARY_PAGETABLE to count secondary page table uses.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 24/08/2022 18:25, Yosry Ahmed wrote:
On Wed, Aug 24, 2022 at 6:42 AM Ryan Roberts <ryan.roberts@xxxxxxx> wrote:

diff --git a/Documentation/filesystems/proc.rst b/Documentation/filesystems/proc.rst
index e7aafc82be99..898c99eae8e4 100644
--- a/Documentation/filesystems/proc.rst
+++ b/Documentation/filesystems/proc.rst
@@ -982,6 +982,7 @@ Example output. You may not have all of these fields.
       SUnreclaim:       142336 kB
       KernelStack:       11168 kB
       PageTables:        20540 kB
+    SecPageTables:         0 kB
       NFS_Unstable:          0 kB
       Bounce:                0 kB
       WritebackTmp:          0 kB
@@ -1090,6 +1091,9 @@ KernelStack
                 Memory consumed by the kernel stacks of all tasks
   PageTables
                 Memory consumed by userspace page tables
+SecPageTables
+              Memory consumed by secondary page tables, this currently
+              currently includes KVM mmu allocations on x86 and arm64.

nit: I think you have a typo here: "currently currently".

Sorry I missed this, thanks for catching it. The below diff fixes it
(let me know if I need to send v8 for this, hopefully not).

diff --git a/Documentation/filesystems/proc.rst
b/Documentation/filesystems/proc.rst
index 898c99eae8e4..0b3778ec12e1 100644
--- a/Documentation/filesystems/proc.rst
+++ b/Documentation/filesystems/proc.rst
@@ -1093,7 +1093,7 @@ PageTables
                Memory consumed by userspace page tables
  SecPageTables
                Memory consumed by secondary page tables, this currently
-              currently includes KVM mmu allocations on x86 and arm64.
+              includes KVM mmu allocations on x86 and arm64.
  NFS_Unstable
                Always zero. Previous counted pages which had been written to
                the server, but has not been committed to stable storage.


Looks good to me!





[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux