---8<--- > > > > > diff --git a/arch/s390/pci/Makefile b/arch/s390/pci/Makefile > > > > > index bf557a1b789c..c02dbfb415d9 100644 > > > > > --- a/arch/s390/pci/Makefile > > > > > +++ b/arch/s390/pci/Makefile > > > > > @@ -7,3 +7,5 @@ obj-$(CONFIG_PCI) += pci.o pci_irq.o pci_dma.o pci_clp.o pci_sysfs.o \ > > > > > pci_event.o pci_debug.o pci_insn.o pci_mmio.o \ > > > > > pci_bus.o > > > > > obj-$(CONFIG_PCI_IOV) += pci_iov.o > > > > > + > > > > > +obj-y += pci_kvm_hook.o > > > > > > > > I thought we wanted to compile this only for CONFIG_PCI? > > > > > > Ah sorry, that is indeed what I understood with Matt but then I > > > misunderstood your own answer from yesterday. > > > I change to > > > obj-$(CONFIG_PCI) += pci_kvm_hook.o > > > > > > > > diff --git a/arch/s390/pci/pci_kvm_hook.c b/arch/s390/pci/pci_kvm_hook.c > > > > > new file mode 100644 > > > > > index 000000000000..ff34baf50a3e > > > > ---8<--- > > > > > > > > Ok with the two things above plus the comment by Matt incorporated: > > > > Reviewed-by: Niklas Schnelle <schnelle@xxxxxxxxxxxxx> > > > > Just a little correction, it changes nothing if the pci_kvm_hook.c goes > on same lines as other CONFIG_PCI depending files. > So I put it on the same line. > > Thanks > > Pierre > Of course yes. Thanks for fixing this and I'm assuming this would either go through the KVM or vfio trees, correct?