The include/linux header should only include things that are intended to be used outside the internal implementation of the vfio_pci_core module. Several internal-only items were left over in this file after the conversion from vfio_pci. Transfer most of the items to a new vfio_pci_priv.h located under drivers/vfio/pci/. Jason Gunthorpe (2): vfio/pci: Split linux/vfio_pci_core.h vfio/pci: Simplify the is_intx/msi/msix/etc defines drivers/vfio/pci/vfio_pci.c | 2 +- drivers/vfio/pci/vfio_pci_config.c | 4 +- drivers/vfio/pci/vfio_pci_core.c | 19 +++- drivers/vfio/pci/vfio_pci_igd.c | 2 +- drivers/vfio/pci/vfio_pci_intrs.c | 28 +++++- drivers/vfio/pci/vfio_pci_priv.h | 104 ++++++++++++++++++++++ drivers/vfio/pci/vfio_pci_rdwr.c | 2 +- drivers/vfio/pci/vfio_pci_zdev.c | 2 +- include/linux/vfio_pci_core.h | 134 +---------------------------- 9 files changed, 156 insertions(+), 141 deletions(-) create mode 100644 drivers/vfio/pci/vfio_pci_priv.h base-commit: 568035b01cfb107af8d2e4bd2fb9aea22cf5b868 -- 2.37.2