On Tue, 2022-08-16 at 15:35 +0000, Sean Christopherson wrote: > On Sun, Aug 07, 2022, isaku.yamahata@xxxxxxxxx wrote: > > +static void tdx_unpin_pfn(struct kvm *kvm, kvm_pfn_t pfn) > > Why does this helper exist? KVM should not be pinning private pages, that should > be the purview of the private backing fd. Agreed. Similar comment made to v7 as well: https://lore.kernel.org/all/20220811182942.GD504743@xxxxxxxxxxxxxxxxxxxxx/t/#m995b4255e0b5a0759c31e4f4cf7be40cdf5ee1a4 -- Thanks, -Kai