On Wed, Aug 10, 2022 at 04:37:47PM -0700, David Matlack wrote: > On Wed, Aug 10, 2022 at 04:33:44PM -0700, David Matlack wrote: > > On Wed, Aug 10, 2022 at 05:58:29PM +0000, Colton Lewis wrote: > > > Randomize which pages are written vs read by using the random number > > > > Same thing here about stating what the patch does first. > > Sorry -- you do state what the patch does first here. But I think it > could just be a little more direct and specific. e.g. > > Replace the -f<fraction> option in dirty_log_perf_test.c with > -w<percent>, to allow the user to specify the percentage of which > pages are written. > > > > > > table for each page modulo 100. This changes how the -w argument > > > works. It is now a percentage from 0 to 100 inclusive that represents > > > what percentage of accesses are writes. It keeps the same default of > > > 100 percent writes. Will do.