On Sun, Aug 07, 2022 at 03:00:45PM -0700, isaku.yamahata@xxxxxxxxx wrote: > From: Isaku Yamahata <isaku.yamahata@xxxxxxxxx> > > KVM TDX basic feature support > > Hello. This is v8 the patch series vof KVM TDX support. > This is based on v5.19-rc8 + kvm/queue branch + TDX HOST patch series. > The tree can be found at https://github.com/intel/tdx/tree/kvm-upstream > How to run/test: It's describe at https://github.com/intel/tdx/wiki/TDX-KVM > > Major changes from v7: > - Use xarray to track whether GFN is private or shared. Drop SPTE_SHARED_MASK. > The complex state machine with SPTE_SHARED_MASK was ditched. > - Large page support is implemented. But will be posted as independent RFC patch. > - fd-based private page v7 is integrated. This is mostly same to Chao's patches. > It's in github. > > Thanks, > Isaku Yamahata > Hi, thanks for the series. When building htmldocs, I found new warnings: Documentation/x86/tdx.rst:69: WARNING: Unexpected indentation. Documentation/x86/tdx.rst:70: WARNING: Block quote ends without a blank line; unexpected unindent. Documentation/virt/kvm/tdx-tdp-mmu.rst: WARNING: document isn't included in any toctree I have applied the fixup (also with line blocks to code blocks conversion): diff --git a/Documentation/virt/kvm/index.rst b/Documentation/virt/kvm/index.rst index cdb8b43ce7970a..ff2db9ab428d3c 100644 --- a/Documentation/virt/kvm/index.rst +++ b/Documentation/virt/kvm/index.rst @@ -20,3 +20,4 @@ KVM review-checklist intel-tdx + tdx-tdp-mmu diff --git a/Documentation/x86/tdx.rst b/Documentation/x86/tdx.rst index 6c6b09ca6ba407..34f0b9e5ee5678 100644 --- a/Documentation/x86/tdx.rst +++ b/Documentation/x86/tdx.rst @@ -62,7 +62,7 @@ use it as 'metadata' for the TDX memory. It also takes additional CPU time to initialize those metadata along with the TDX module itself. Both are not trivial. Current kernel doesn't choose to always initialize the TDX module during kernel boot, but provides a function tdx_init() to -allow the caller to initialize TDX when it truly wants to use TDX: +allow the caller to initialize TDX when it truly wants to use TDX:: ret = tdx_init(); if (ret) @@ -79,20 +79,20 @@ caller. User can consult dmesg to see the presence of the TDX module, and whether it has been initialized. -If the TDX module is not loaded, dmesg shows below: +If the TDX module is not loaded, dmesg shows below:: -| [..] tdx: TDX module is not loaded. + [..] tdx: TDX module is not loaded. If the TDX module is initialized successfully, dmesg shows something -like below: +like below:: -| [..] tdx: TDX module: vendor_id 0x8086, major_version 1, minor_version 0, build_date 20211209, build_num 160 -| [..] tdx: 65667 pages allocated for PAMT. -| [..] tdx: TDX module initialized. + [..] tdx: TDX module: vendor_id 0x8086, major_version 1, minor_version 0, build_date 20211209, build_num 160 + [..] tdx: 65667 pages allocated for PAMT. + [..] tdx: TDX module initialized. -If the TDX module failed to initialize, dmesg shows below: +If the TDX module failed to initialize, dmesg shows below:: -| [..] tdx: Failed to initialize TDX module. Shut it down. + [..] tdx: Failed to initialize TDX module. Shut it down. TDX Interaction to Other Kernel Components ------------------------------------------ @@ -143,10 +143,10 @@ There are basically two memory hot-add cases that need to be prevented: ACPI memory hot-add and driver managed memory hot-add. The kernel rejectes the driver managed memory hot-add too when TDX is enabled by BIOS. For instance, dmesg shows below error when using kmem driver to -add a legacy PMEM as system RAM: +add a legacy PMEM as system RAM:: -| [..] tdx: Unable to add memory [0x580000000, 0x600000000) on TDX enabled platform. -| [..] kmem dax0.0: mapping0: 0x580000000-0x5ffffffff memory add failed + [..] tdx: Unable to add memory [0x580000000, 0x600000000) on TDX enabled platform. + [..] kmem dax0.0: mapping0: 0x580000000-0x5ffffffff memory add failed However, adding new memory to ZONE_DEVICE should not be prevented as those pages are not managed by the page allocator. Therefore, Thanks. -- An old man doll... just what I always wanted! - Clara
Attachment:
signature.asc
Description: PGP signature
