On Sat, Aug 06, 2022 at 11:52:13PM -0700, Christoph Hellwig wrote: > It really is vhost that seems to abuse it so that if the guest > claims it can handle VIRTIO_F_ACCESS_PLATFORM (which every modern > guest should) it enables magic behavior, which I don't think is what > the virtio spec intended. Well the magic behavour happens to be used by QEMU to implement a virtual IOMMU. And when you have a virtual IOMMU you generally want VIRTIO_F_ACCESS_PLATFORM. This is how it came to be reused for that. And since QEMU never passed guest features to vhost unfiltered we never saw the issue even with old QEMU versions on new kernels. It seems natural to pass features unfiltered and we never even said userspace should not do it, so it's quite understandable that this is what corsvm did. -- MST
