Hi Mingwei, On Tue, Aug 02, 2022 at 11:07:15PM +0000, Mingwei Zhang wrote: > Fix vcpu_{save,load}_state() by adding APIC state into kvm_x86_state and > properly save/restore it in vcpu_{save,load}_state(). When vcpu resets, > APIC state become software disabled in kernel and thus the corresponding > vCPU is not able to receive posted interrupts [1]. So, add APIC > save/restore in userspace in selftest library code. Of course, there are no hard rules around it but IMO a changelog is easier to grok if it first describes the what/why of the problem, then afterwards how it is fixed by the commit. > [1] commit 97222cc83163 ("KVM: Emulate local APIC in kernel"). What is the reason for the citation here? > Cc: Jim Mattson <jmattson@xxxxxxxxxx> > nit: no newline between footers. > Signed-off-by: Mingwei Zhang <mizhang@xxxxxxxxxx> -- Thanks, Oliver