On Tue, Aug 2, 2022 at 5:19 PM Jim Mattson <jmattson@xxxxxxxxxx> wrote: > > On Fri, Jul 8, 2022 at 6:17 PM Aaron Lewis <aaronlewis@xxxxxxxxxx> wrote: > > > > +#define KVM_PMU_EVENT_ENCODE_MASKED_EVENT(select, mask, match, invert) \ > > + (((select) & 0xfful) | (((select) & 0xf00ul) << 24) | \ > > + (((mask) & 0xfful) << 24) | \ > > + (((match) & 0xfful) << 8) | \ > > + (((invert) & 0x1ul) << 23)) > > Please convert the masks and shifts to GENMASK_ULL(). Sorry. Ignore this suggestion. It makes no sense.