On Fri, Jul 29, 2022 at 09:41:02AM +0200, Greg KH wrote: > On Thu, Jul 28, 2022 at 02:47:37PM -0500, Coleman Dietsch wrote: > > This crash appears to be happening when vcpu->arch.xen.timer is already set and kvm_xen_init_timer(vcpu) is called. > > What does "this crash" refer to ? > > > > > During testing with the syzbot reproducer code it seemed apparent that the else if statement in the KVM_XEN_VCPU_ATTR_TYPE_TIMER switch case was not being reached, which is where the kvm_xen_stop_timer(vcpu) call is located. > > Please properly wrap your kernel changelog at 72 columns. > > Didn't checkpatch.pl complain about this? > I believe I made the mistake of editing the patch file directly so it was on me for forgetting to run checkpatch.pl manually. > thanks, > > greg k-h Thanks for the feedback Greg, I believe I have (at least these) issues resolved in the next version of the patch.
