On Fri, Jul 29, 2022, Vincent Mailhol wrote: > arch/x86/include/asm/apic.h declares a global variable named `apic'. > > Many function arguments from arch/x86/kvm/lapic.h also uses the same > name and thus shadow the global declaration. For each case of > shadowing, rename the function argument from `apic' to `lapic'. > > This patch silences below -Wshadow warnings: This is just the tip of the iceberg, nearly every KVM x86 .c file has at least one "apic" variable. arch/x86/kvm/lapic.c alone has nearly 100. If this were the very last step before a kernel-wide (or even KVM-wide) enabling of -Wshadow then maybe it would be worth doing, but as it stands IMO it's unnecesary churn. What I would really love is to not have the global (and exported!) "apic", but properly solving that, i.e. not just a rename, would require a significant rework.
