On 7/28/22 20:55, Sean Christopherson wrote: > On Fri, Jul 15, 2022, Dmytro Maluka wrote: >> +static void >> +irqfd_resampler_mask(struct kvm_irq_mask_notifier *kimn, bool masked) > > Ugh, I see you're just following the existing "style" in this file. Linus provided > a lengthy explanation of why this style is unwanted[*]. And this file is straight up > obnoxious, e.g. a large number of functions put the return type on a separate line > even though it would fit without any wrap. > > My vote is to break from this file's style for this patch, and then do a follow-up > patch to fix all the existing funky wraps. Ok, I can do that. Would you also like if I rename resampler->notifier to resampler->ack_notifier and irqfd_resampler_mask() to irqfd_resampler_mask_notify() for more clarity? Thanks, Dmytro > [*] https://lore.kernel.org/all/CAHk-=wjoLAYG446ZNHfg=GhjSY6nFmuB_wA8fYd5iLBNXjo9Bw@xxxxxxxxxxxxxx
