On Tue, Jul 12, 2022 at 10:36:57AM +0800, Yuan Yao <yuan.yao@xxxxxxxxxxxxxxx> wrote: > > diff --git a/arch/x86/kvm/mmu/paging_tmpl.h b/arch/x86/kvm/mmu/paging_tmpl.h > > index 62ae590d4e5b..e5b73638bd83 100644 > > --- a/arch/x86/kvm/mmu/paging_tmpl.h > > +++ b/arch/x86/kvm/mmu/paging_tmpl.h > > @@ -877,7 +877,7 @@ static int FNAME(page_fault)(struct kvm_vcpu *vcpu, struct kvm_page_fault *fault > > > > out_unlock: > > write_unlock(&vcpu->kvm->mmu_lock); > > - kvm_release_pfn_clean(fault->pfn); > > + kvm_mmu_release_fault(vcpu->kvm, fault, r); > > Do we really need this? Shadow page table is not supported for TD guest. For consistency. pair of kvm_faultin_pfn() and kvm_mmu_release_fault(). -- Isaku Yamahata <isaku.yamahata@xxxxxxxxx>