Hi, Thank you for fixing this, I've come across it several times in the past. On Fri, Jul 22, 2022 at 03:17:30PM +0100, Jean-Philippe Brucker wrote: > Variables set on the command-line are not overridden by normal > assignments. So when passing ARCH=x86_64 on the command-line, build > fails: > > Makefile:227: *** This architecture (x86_64) is not supported in kvmtool. > > Use the 'override' directive to force the ARCH reassignment. > > Signed-off-by: Jean-Philippe Brucker <jean-philippe@xxxxxxxxxx> > --- > Makefile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Makefile b/Makefile > index f0df76f4..faae0da2 100644 > --- a/Makefile > +++ b/Makefile > @@ -115,11 +115,11 @@ ARCH ?= $(shell uname -m | sed -e s/i.86/i386/ -e s/ppc.*/powerpc/ \ > -e s/riscv64/riscv/ -e s/riscv32/riscv/) > > ifeq ($(ARCH),i386) As far as I know, there are several versions of the x86 architecture: i386, i486, i586 and i686. It looks rather arbitrary to have i386 as a valid ARCH value, but not the other ix86 versions. I wonder if we should just drop it and keep only x86 and x86_64, like the kernel. Regardless, the patch looks good to me: Tested-by: Alexandru Elisei <alexandru.elisei@xxxxxxx> Reviewed-by: Alexandru Elisei <alexandru.elisei@xxxxxxx> Thanks, Alex > - ARCH := x86 > + override ARCH = x86 > DEFINES += -DCONFIG_X86_32 > endif > ifeq ($(ARCH),x86_64) > - ARCH := x86 > + override ARCH = x86 > DEFINES += -DCONFIG_X86_64 > ARCH_PRE_INIT = x86/init.S > endif > -- > 2.37.1 >
