Re: [PATCH v2 10/11] KVM: x86: SVM: use smram structs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v2 10/11] KVM: x86: SVM: use smram structs
From: Maxim Levitsky <mlevitsk@xxxxxxxxxx>
Date: Thu, 21 Jul 2022 14:54:54 +0300
Cc: kvm@xxxxxxxxxxxxxxx, x86@xxxxxxxxxx, Kees Cook <keescook@xxxxxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, "H. Peter Anvin" <hpa@xxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, Joerg Roedel <joro@xxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Vitaly Kuznetsov <vkuznets@xxxxxxxxxx>, Wanpeng Li <wanpengli@xxxxxxxxxxx>, Jim Mattson <jmattson@xxxxxxxxxx>
In-reply-to: <YtigJfHmyTr3eE5v@google.com>
References: <20220621150902.46126-1-mlevitsk@redhat.com> <20220621150902.46126-11-mlevitsk@redhat.com> <YtigJfHmyTr3eE5v@google.com>
User-agent: Evolution 3.36.5 (3.36.5-2.fc32)

On Thu, 2022-07-21 at 00:39 +0000, Sean Christopherson wrote:
> On Tue, Jun 21, 2022, Maxim Levitsky wrote:
> > +	if (!guest_cpuid_has(vcpu, X86_FEATURE_SVM))
> 
> I think you want X86_FEATURE_LM, not X86_FEATURE_SVM.
> 

Yes, sorry about that! Thanks!

Best regards,
	Maxim Levitsky

References:
- [PATCH v2 00/11] SMM emulation and interrupt shadow fixes
  - From: Maxim Levitsky
- [PATCH v2 10/11] KVM: x86: SVM: use smram structs
  - From: Maxim Levitsky
- Re: [PATCH v2 10/11] KVM: x86: SVM: use smram structs
  - From: Sean Christopherson

Prev by Date: Re: [RFC 0/5] In virtio-spec 1.1, new feature bit VIRTIO_F_IN_ORDER was introduced.
Next by Date: Re: [PATCH 4/7] KVM: SVM: Report NMI not allowed when Guest busy handling VNMI
Previous by thread: Re: [PATCH v2 10/11] KVM: x86: SVM: use smram structs
Next by thread: [PATCH v2 08/11] KVM: x86: emulator/smm: use smram struct for 32 bit smram load/restore
Index(es):
- Date
- Thread

[Index of Archives] [KVM ARM] [KVM ia64] [KVM ppc] [Virtualization Tools] [Spice Development] [Libvirt] [Libvirt Users] [Linux USB Devel] [Linux Audio Users] [Yosemite Questions] [Linux Kernel] [Linux SCSI] [XFree86]