> Rather than add a third helper, what about renaming kvm_apic_set_eoi_accelerated() and having the non-accelerated helper call the "acclerated" version? That will document the delta between the non-accelerated patch and the accelerated path. > The only hiccup is tracing, but that's easy to resolve (or we could just not trace if there's no valid vector to EOI), e.g. Yeah, rename the function and integrate two paths looks clearer and easier to understand? Thanks Sean for the suggestion, I will send a new patch with a new subject and changelog. -- Wang
