On Thu, Jun 30, 2022, Mingwei Zhang wrote: > On Fri, Apr 8, 2022 at 12:52 PM Sean Christopherson <seanjc@xxxxxxxxxx> wrote: > > > > On Wed, Mar 30, 2022, Ben Gardon wrote: > > > Add kvm_util library functions to read KVM stats through the binary > > > stats interface and then dump them to stdout when running the binary > > > stats test. Subsequent commits will extend the kvm_util code and use it > > > to make assertions in a test for NX hugepages. > > > > Why? Spamming my console with info that has zero meaning to me and is useless > > when the test passes is not helpful. Even on failure, I don't see what the user > > is going to do with this information, all of the asserts are completly unrelated > > to the stats themselves. > > Debugging could be another reason, I suspect? I remember when I tried > to use the interface, there is really no API that tells me "did I add > this stat successfully and/or correctly?" I think having a general > print so that developer/debugging folk could just 'grep mystat' to > verify that would be helpful in the future. > > Otherwise, they have to write code themselves to do the dirty print... I've no objection to adding a --verbose option or a #define of some form, but make it opt-in, not on by default.
