Re: [PATCH 15/15] vfio/mdev: remove an extra parent kobject reference

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 15/15] vfio/mdev: remove an extra parent kobject reference
From: Christoph Hellwig <hch@xxxxxx>
Date: Thu, 7 Jul 2022 15:40:52 +0200
Cc: Christoph Hellwig <hch@xxxxxx>, Kirti Wankhede <kwankhede@xxxxxxxxxx>, Tony Krowiak <akrowiak@xxxxxxxxxxxxx>, Halil Pasic <pasic@xxxxxxxxxxxxx>, Jason Herne <jjherne@xxxxxxxxxxxxx>, Eric Farman <farman@xxxxxxxxxxxxx>, Matthew Rosato <mjrosato@xxxxxxxxxxxxx>, Zhenyu Wang <zhenyuw@xxxxxxxxxxxxxxx>, Zhi Wang <zhi.a.wang@xxxxxxxxx>, Alex Williamson <alex.williamson@xxxxxxxxxx>, kvm@xxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, intel-gvt-dev@xxxxxxxxxxxxxxxxxxxxx
In-reply-to: <20220706143833.GD693670@nvidia.com>
References: <20220706074219.3614-1-hch@lst.de> <20220706074219.3614-16-hch@lst.de> <20220706143833.GD693670@nvidia.com>
User-agent: Mutt/1.5.17 (2007-11-01)

On Wed, Jul 06, 2022 at 11:38:33AM -0300, Jason Gunthorpe wrote:
> On Wed, Jul 06, 2022 at 09:42:19AM +0200, Christoph Hellwig wrote:
> > The mdev_type already holds a reference to the parent through
> > mdev_types_kset, so drop the extra reference.
> 
> I would drop this patch, but at least the explanation needs tweaking..

I'm fine with that.  Alex, any preferences?

Follow-Ups:
- Re: [PATCH 15/15] vfio/mdev: remove an extra parent kobject reference
  - From: Alex Williamson

References:
- simplify the mdev interface v5
  - From: Christoph Hellwig
- [PATCH 15/15] vfio/mdev: remove an extra parent kobject reference
  - From: Christoph Hellwig
- Re: [PATCH 15/15] vfio/mdev: remove an extra parent kobject reference
  - From: Jason Gunthorpe

Prev by Date: Re: [PATCH 04/15] vfio/mdev: embedd struct mdev_parent in the parent data structure
Next by Date: [PATCH kernel] powerpc/iommu: Add iommu_ops to report capabilities and allow blocking domains
Previous by thread: Re: [PATCH 15/15] vfio/mdev: remove an extra parent kobject reference
Next by thread: Re: [PATCH 15/15] vfio/mdev: remove an extra parent kobject reference
Index(es):
- Date
- Thread

[Index of Archives] [KVM ARM] [KVM ia64] [KVM ppc] [Virtualization Tools] [Spice Development] [Libvirt] [Libvirt Users] [Linux USB Devel] [Linux Audio Users] [Yosemite Questions] [Linux Kernel] [Linux SCSI] [XFree86]