On Tue, Jul 05, 2022 at 11:56:25PM -0700, Christoph Hellwig wrote: > > - vfio_unpin_pages(&q->matrix_mdev->vdev, &q->saved_pfn, 1); > > + vfio_unpin_pages(&q->matrix_mdev->vdev, q->saved_pfn << PAGE_SHIFT, 1); > > Overly long line here. The following PATCH-5 drops the "<< PAGE_SHIFT", addressing this. To not wrapping and unwrapping a line back and forth, I think we are fine here? > Reviewed-by: Christoph Hellwig <hch@xxxxxx> Will add to v3. Thanks for the review!
