On Mon, Jun 20, 2022 at 02:04:43PM +0200, Paolo Bonzini wrote:
> On 6/16/22 14:45, Andrew Jones wrote:
> > > +#define __GUEST_ASSERT(_condition, _condstr, _nargs, _args...) do { \
> > > + if (!(_condition)) \
> > > + ucall(UCALL_ABORT, GUEST_ASSERT_BUILTIN_NARGS + _nargs, \
> > > + "Failed guest assert: " _condstr, \
> > > + __FILE__, \
> > > + __LINE__, \
> > > + ##_args); \
> > We don't need another level of indentation nor the ## operator on _args.
> >
>
> The ## is needed to drop the comma if there are no _args.
I haven't heard anything more about part 4 of this patch in a while,
so I'm checking in that I didn't miss something requiring action on my
part.
