Hi Drew
Thanks for the review!
On 01/07/2022 10:27, Andrew Jones wrote:
Hi Nikos,
I guess you used Linux's scripts/Lindent or something for this
conversion. Can you please specify what you used/did in the
commit message?
I fixed the style by hand but happy to use Lindent in the next iteration.
On Thu, Jun 30, 2022 at 11:02:58AM +0100, Nikos Nikoleris wrote:
Signed-off-by: Nikos Nikoleris <nikos.nikoleris@xxxxxxx>
---
lib/acpi.h | 148 ++++++++++++++++++++++++++---------------------------
lib/acpi.c | 70 ++++++++++++-------------
2 files changed, 108 insertions(+), 110 deletions(-)
It looks like the series is missing the file move patch. Latest master
still doesn't have lib/acpi.*
I am sorry, I missed the first patch. The missing patch is doing a move
of acpi.{h,c} [1].
FWIW, I tried combining the patches in one but I ended up with a big
diff. I found it much easier to check that everything looks ok when the
overall change was split in two patches.
[1]:
https://github.com/relokin/kvm-unit-tests/commit/959ca08c23dbaa490b936303b94b006352a29d43
Thanks,
Nikos
Thanks,
drew
