Quoting Thomas Huth (2022-06-30 19:49:45)
> On 30/06/2022 13.30, Nico Boehr wrote:
> > QEMU suports a guest state "guest-panicked" which indicates something in
>
> s/suports/supports/
Fixed.
> > diff --git a/scripts/arch-run.bash b/scripts/arch-run.bash
> > index 0dfaf017db0a..5663a1ddb09e 100644
> > --- a/scripts/arch-run.bash
> > +++ b/scripts/arch-run.bash
> > @@ -104,6 +104,12 @@ qmp ()
> > echo '{ "execute": "qmp_capabilities" }{ "execute":' "$2" '}' | ncat -U $1
> > }
> >
> > +qmp_events ()
> > +{
> > + while ! test -S "$1"; do sleep 0.1; done
> > + echo '{ "execute": "qmp_capabilities" }{ "execute": "cont" }' | ncat --no-shutdown -U $1 | jq -c 'select(has("event"))'
>
> Break the long line into two or three?
Fixed.
> > +run_panic ()
> > +{
[...]
> > + panic_event_count=$(qmp_events ${qmp} | jq -c 'select(.event == "GUEST_PANICKED")' | wc -l)
> > + if [ $panic_event_count -lt 1 ]; then
>
> Maybe put double-quotes around $panic_event_count , just to be sure?
Yes, quoting is a bit broken anyways, but we have to start somewhere, thanks.
> With the nits fixed:
>
> Reviewed-by: Thomas Huth <thuth@xxxxxxxxxx>
Thanks.
