On Thu, Jun 30, 2022 at 12:01:53PM -0700, John Hubbard wrote: > On 6/30/22 06:49, Peter Xu wrote: > > Looks good to me, I'd tune a bit to make it less ambiguous on a few places: > > > > /* > > * FAULT_FLAG_INTERRUPTIBLE is opt-in. GUP callers must set > > * FOLL_INTERRUPTIBLE to enable FAULT_FLAG_INTERRUPTIBLE. > > * That's because some callers may not be prepared to > > * handle early exits caused by non-fatal signals. > > */ > > > > Would that be okay to you? > > > > Yes, looks good. With that change, please feel free to add: > > Reviewed-by: John Hubbard <jhubbard@xxxxxxxxxx> Will do, thanks! -- Peter Xu
