> > The most recent patches I recall for SEV-SNP introduced a new > > 'sev-snp-guest' object instead of overloading the existing > > 'sev-guest' object: > > > > https://lists.gnu.org/archive/html/qemu-devel/2021-08/msg04757.html > > > > Correct, the SNP support for Qemu is only RFC at this point until the KVM > support for SNP is (near) finalized. > Ah okay, should I wait until that RFC patch set is merged to propose an extension to it, or should I coordinate with y'all at AMD to include this in your patch set? Apologies Pankaj, I forgot the change log (still new to git send-email). The change is that the configuration option is no longer in MachineState, but part of SevGuestState, with accessor functions for fw_cfg.c to know if it needs to add the fw_cfg file and what its value should be. That was the main feedback on v1. -- -Dionna Glaze, PhD (she/her)