> From: Liam Ni <zhiguangni01@xxxxxxxxx> > Sent: Saturday, June 25, 2022 7:43 PM > > As iommu_group_set_name() can fail,we should check the return value. > > Signed-off-by: Liam Ni <zhiguangni01@xxxxxxxxx> Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>. btw you probably also want to change other callers of this function for the same issue. > --- > drivers/vfio/vfio.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/vfio/vfio.c b/drivers/vfio/vfio.c > index 61e71c1154be..ca823eeac237 100644 > --- a/drivers/vfio/vfio.c > +++ b/drivers/vfio/vfio.c > @@ -504,7 +504,9 @@ static struct vfio_group > *vfio_noiommu_group_alloc(struct device *dev, > if (IS_ERR(iommu_group)) > return ERR_CAST(iommu_group); > > - iommu_group_set_name(iommu_group, "vfio-noiommu"); > + ret = iommu_group_set_name(iommu_group, "vfio-noiommu"); > + if (ret) > + goto out_put_group; > ret = iommu_group_add_device(iommu_group, dev); > if (ret) > goto out_put_group; > -- > 2.25.1
