On Fri, 2022-06-24 at 12:47 -0700, Dave Hansen wrote: > On 6/22/22 04:15, Kai Huang wrote: > > Please kindly help to review, and I would appreciate reviewed-by or > > acked-by tags if the patches look good to you. > > Serious question: Is *ANYONE* looking at these patches other than you > and the maintainers? I first saw this code (inside Intel) in early > 2020. In that time, not a single review tag has been acquired? > > $ egrep -ic 'acked-by:|reviewed-by:' kais-patches.mbox > 0 Hi Dave, There were big design changes in the history of this series (i.e. we originally supported loading both the NP-SEAMLDR ACM and the TDX module during boot, and we changed from initializing the module from during kernel boot to at runtime), but yes some other Linux/KVM TDX developers in our team have been reviewing this series during the all time, at least at some extent. They just didn't give Reviewed-by or Acked-by. Especially, after we had agreed that this series in general should enable TDX with minimal code change, Kevin helped to review this series intensively and helped to simplify the code to the current shape (i.e. TDMR part). He didn't give any of tags either (only said this series is ready for you to review), perhaps because he was _helping_ to get this series to the shape that is ready for you and other Intel reviewers to review. -- Thanks, -Kai
