[Public] >> +EXPORT_SYMBOL_GPL(snp_guest_decommission); >> + >> +int snp_guest_df_flush(int *error) >> +{ >> + return sev_do_cmd(SEV_CMD_SNP_DF_FLUSH, NULL, error); } >> +EXPORT_SYMBOL_GPL(snp_guest_df_flush); >Why not instead change sev_guest_df_flush() to be SNP aware? That way callers get the right behavior without having to know if SNP is enabled or not. It can be done, and actually both DF_FLUSH commands do exactly the same thing. But as with other API interfaces here, I think it is better to differentiate between snp and sev API interfaces and the callers be aware of which interface they are invoking. Thanks, Ashish