On Thu, Jun 16, 2022, Paolo Bonzini wrote: > On 4/29/22 03:04, Sean Christopherson wrote: > > - > > +/* > > + * Note, checking for an error/noslot pfn is the caller's responsibility when > > + * directly marking a page dirty/accessed. Unlike the "release" helpers, the > > + * "set" helpers are not to be unused when the pfn might point at garbage. > > + */ > > s/unused/unused/ LOL, s/unused/used? :-) > But while at it, I'd rather add a WARN_ON(is_error_noslot_pfn(pfn)). I've no objection to that. IIRC, I almost added it myself, but my mental coin flip came up wrong.
