On Tue, Jun 14, 2022, Lai Jiangshan wrote: > On Tue, Jun 14, 2022 at 6:59 AM Sean Christopherson <seanjc@xxxxxxxxxx> wrote: > > > > Move a handful of one-off macros and helpers for 32-bit PSE paging into > > paging_tmpl.h and hide them behind "PTTYPE == 32". Under no circumstance > > should anything but 32-bit shadow paging care about PSE paging. > > > > Moving code from paging_tmp.h is on my to-do list. > I don't think the opposite direction is preferred. > > And is_cpuid_PSE36() is also used in mmu.c, is it a good idea to move > it into paging_tmp.h? Huh. I've no idea how I missed that every time. It definite should stay in mmu.c.
