RE: [PATCH v1 13/18] vfio/mdev: Consolidate all the device_api sysfs into the core code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> From: Eric Farman
> Sent: Friday, June 3, 2022 1:20 AM
> 
> From: Jason Gunthorpe <jgg@xxxxxxxxxx>
> 
> Every driver just emits a static string, simply feed it through the ops
> and provide a standard sysfs show function.
> 
> Cc: Kirti Wankhede <kwankhede@xxxxxxxxxx>
> Cc: Jonathan Corbet <corbet@xxxxxxx>
> Cc: Zhenyu Wang <zhenyuw@xxxxxxxxxxxxxxx>
> Cc: Zhi Wang <zhi.a.wang@xxxxxxxxx>
> Cc: Tony Krowiak <akrowiak@xxxxxxxxxxxxx>
> Cc: Jason Herne <jjherne@xxxxxxxxxxxxx>
> Cc: intel-gvt-dev@xxxxxxxxxxxxxxxxxxxxx
> Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxx>
> Link: https://lore.kernel.org/r/6-v3-57c1502c62fd+2190-
> ccw_mdev_jgg@xxxxxxxxxx/
> [farman: added Cc: tags]
> Signed-off-by: Eric Farman <farman@xxxxxxxxxxxxx>

Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>, with one nit:

> @@ -225,7 +226,8 @@ Directories and files under the sysfs for Each Physical
> Device
>  * device_api
> 
>    This attribute should show which device API is being created, for example,
> -  "vfio-pci" for a PCI device.
> +  "vfio-pci" for a PCI device. The core code maintins this sysfs using the
> +  device_api member of mdev_parent_ops.
> 

s/maintins/maintains/




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux