> From: Christoph Hellwig <hch@xxxxxx> > Sent: Tuesday, June 7, 2022 1:49 PM > > >> - mdev_unregister_device(i915->drm.dev); > >> + mdev_unregister_parent(&i915->vgpu.parent); > > > > Ideally, parent should be member of gvt. There could be multiple vgpus > > created on one physical device. Intel folks would be better reviewer > > though. > > i915->vgpu is not for a single VGPU, but all VGPU related core > support. > Yes i915->gpu is per parent, but i915->gvt is a better fit. The former is solely for mmio snapshot while the latter contains everything actually related to vgpu core support. apart from that, Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>